-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebSocketShard): don't await #destroy in error bubbling logic #9276
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-didinele-fix-dont-await-destroy-discordjs.vercel.app/ |
Codecov Report
@@ Coverage Diff @@
## main #9276 +/- ##
==========================================
- Coverage 83.56% 83.54% -0.02%
==========================================
Files 100 100
Lines 9572 9574 +2
Branches 1103 1103
==========================================
Hits 7999 7999
- Misses 1533 1535 +2
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beginner mistake.
true |
Please describe the changes this PR makes and why it should be merged:
and also an addition to the readme
Status and versioning classification: