Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): include data for defer #9284

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

vladfrangu
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Missed this somehow

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Mar 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2023 11:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2023 11:32pm

@github-actions
Copy link

github-actions bot commented Mar 27, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-fix-core-forgot-to-includ-6f66ed-discordjs.vercel.app/

@iCrawl iCrawl force-pushed the fix/core-forgot-to-include-defer-options branch from b7c63b7 to ad2b9d8 Compare April 1, 2023 23:31
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Merging #9284 (b7c63b7) into main (ab3328a) will increase coverage by 23.61%.
The diff coverage is n/a.

❗ Current head b7c63b7 differs from pull request most recent head d3f633a. Consider uploading reports for the commit d3f633a to get more accurate results

@@             Coverage Diff             @@
##             main    #9284       +/-   ##
===========================================
+ Coverage   59.93%   83.54%   +23.61%     
===========================================
  Files         214      100      -114     
  Lines       13726     9574     -4152     
  Branches     1246     1103      -143     
===========================================
- Hits         8226     7999      -227     
+ Misses       5460     1535     -3925     
  Partials       40       40               
Flag Coverage Δ
guide ?
website ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 119 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iCrawl iCrawl force-pushed the fix/core-forgot-to-include-defer-options branch from ad2b9d8 to d3f633a Compare April 1, 2023 23:31
@iCrawl iCrawl merged commit 9d69bba into main Apr 1, 2023
@iCrawl iCrawl deleted the fix/core-forgot-to-include-defer-options branch April 1, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants