Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I think we should stop referencing this TypeScript interface in our JavaScript documentation.
Look at this:
discord.js/packages/discord.js/src/structures/ActionRowBuilder.js
Lines 19 to 31 in 1b9d07f
JSONEncodable<APIActionRowComponent<APIActionRowComponentTypes>>|APIActionRowComponent<APIActionRowComponentTypes>
. Well damn. This is the same type duplicated withJSONEncodable
.The proposed modification:
ActionRow|ActionRowBuilder|APIActionRowComponent
. Wow, much more understandable, right?JavaScript users only need to know what they can pass without needing to deeply understand all associated typings. One may pass a received (immutable)
ActionRow
from the API, anActionRowBuilder
, or use raw API data. This is the exact same behaviour from before but is documented in a simpler way that could be understood with ease.I believe this change will allow users to understand this part of the documentation better.
Status and versioning classification: