perf(RoleManager): dont call Role#position getter twice per role #9352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Stored the position of the roles to not call the
position
getter twice per role as it is a reasonably heavy operationRole#position
discord.js/packages/discord.js/src/structures/Role.js
Lines 186 to 189 in b2eec5f
discord.js/packages/discord.js/src/structures/Guild.js
Lines 1296 to 1298 in b2eec5f
discord.js/packages/discord.js/src/util/Util.js
Lines 270 to 277 in b2eec5f
Status and versioning classification: