Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create-discord-bot #9420

Merged
merged 55 commits into from
May 7, 2023
Merged

feat: create-discord-bot #9420

merged 55 commits into from
May 7, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Apr 19, 2023 •
edited
Loading

Description

Something you can easily run npx create-discord-bot ./directory to get a startup bot.

This will be useful for the guide!

Progress

  • Add TypeScript
  • Add package manager inference
  • Add links instead of just "guide"
  • Event handler

Iterations can be done in the future.

@vercel
Copy link

vercel bot commented Apr 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 7, 2023 3:59pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 7, 2023 3:59pm

imranbarbhuiya
imranbarbhuiya suggested changes Apr 19, 2023
View reviewed changes
.github/issue-labeler.yml Outdated Show resolved Hide resolved
packages/create-discord-bot/src/index.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/template/index.js Outdated Show resolved Hide resolved
packages/create-discord-bot/package.json Outdated Show resolved Hide resolved
packages/create-discord-bot/src/index.ts Outdated Show resolved Hide resolved
@Jiralite Jiralite mentioned this pull request Apr 19, 2023
Merged
@Jiralite Jiralite force-pushed the feat/create-discord-bot branch 2 times, most recently from 2595373 to 431eb6a Compare April 19, 2023 20:35
TetieWasTaken
TetieWasTaken reviewed Apr 22, 2023
View reviewed changes
Copy link
Contributor

@TetieWasTaken TetieWasTaken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package manager option. I don't think we should use npm_config_user_agent since that can (?) include multiple different managers.

packages/create-discord-bot/src/index.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/src/index.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/src/index.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/src/index.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 24, 2023 •
edited
Loading

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 99
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-feat-create-discord-bot-discordjs.vercel.app/

@Jiralite Jiralite marked this pull request as ready for review May 7, 2023 09:35
@Jiralite Jiralite requested a review from iCrawl as a code owner May 7, 2023 09:35
@iCrawl iCrawl added the blocked label May 7, 2023
iCrawl
iCrawl requested changes May 7, 2023
View reviewed changes
packages/create-discord-bot/package.json Outdated Show resolved Hide resolved
packages/create-discord-bot/.gitignore Outdated Show resolved Hide resolved
packages/create-discord-bot/.gitignore Outdated Show resolved Hide resolved
packages/create-discord-bot/package.json Show resolved Hide resolved
packages/create-discord-bot/package.json Outdated Show resolved Hide resolved
packages/create-discord-bot/src/create-discord-bot.ts Show resolved Hide resolved
packages/create-discord-bot/src/create-discord-bot.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/src/helpers/packageManager.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/src/helpers/packageManager.ts Outdated Show resolved Hide resolved
packages/create-discord-bot/template/TypeScript/package.json Outdated Show resolved Hide resolved
Jiralite and others added 2 commits May 7, 2023 16:56
@Jiralite @iCrawl
chore: requested changes
0835df2 
Co-authored-by: Noel <buechler.noel@outlook.com>
@Jiralite @iCrawl
chore: more requested changes
b08758c 
Co-authored-by: Noel <buechler.noel@outlook.com>
@iCrawl iCrawl merged commit f83a8a5 into main May 7, 2023
@iCrawl iCrawl deleted the feat/create-discord-bot branch May 7, 2023 16:05
@SuperchupuDev SuperchupuDev mentioned this pull request May 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TetieWasTaken TetieWasTaken TetieWasTaken left review comments

@jaw0r3k jaw0r3k jaw0r3k left review comments

@iCrawl iCrawl iCrawl requested changes

@imranbarbhuiya imranbarbhuiya imranbarbhuiya requested changes

@almeidx almeidx Awaiting requested review from almeidx

Assignees
No one assigned
Labels
packages:create-discord-bot
Projects
discord.js
Archived in project
Milestone
create-discord-bot 0.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Jiralite @jaw0r3k @iCrawl @almeidx @TetieWasTaken @imranbarbhuiya