Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ShardClientUtil): Fix client event names #9474

Merged
merged 3 commits into from
Apr 30, 2023

Conversation

GrapeColor
Copy link
Contributor

@GrapeColor GrapeColor commented Apr 29, 2023

Please describe the changes this PR makes and why it should be merged:
Fix the client event name in ShardClientUtil to the correct name.
The reason is that Shard#reconnecting and Shard#disconnect do not emit.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@GrapeColor GrapeColor requested a review from a team as a code owner April 29, 2023 18:52
@vercel
Copy link

vercel bot commented Apr 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 10:22am
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2023 10:22am

@github-actions
Copy link

github-actions bot commented Apr 29, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 87
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-git-fork-grapecolor-fix-shard-clien-5caeae-discordjs.vercel.app/

@Jiralite Jiralite added this to the discord.js 14.10 milestone Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants