refactor(GuildChannel): simplify constructor #9499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
this.parentId = this.parentId ?? null
was an useless call sincethis.parentId
isundefined
at construct (as the parent class doesn't assign it either), therefore the check was moved to the_patch
method with a default, consistent with the rest of structures.guild?.client
is an unnecessary check whenclient
is already passed and always guaranteed to exist. Removing this check allows us to reduce some overhead when creating channels.🤖 Generated by Copilot at 6a83a0f
Status and versioning classification: