Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebSocketShard): wait a little before reconnecting #9517

Merged
merged 3 commits into from
May 5, 2023

Conversation

didinele
Copy link
Member

@didinele didinele commented May 5, 2023

Please describe the changes this PR makes and why it should be merged:
Closes #9510

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 5, 2023 8:11pm
discord-js-guide ⬜️ Ignored (Inspect) May 5, 2023 8:11pm

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #9517 (44ef54c) into main (ab39683) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

❗ Current head 44ef54c differs from pull request most recent head 136e1fc. Consider uploading reports for the commit 136e1fc to get more accurate results

@@            Coverage Diff             @@
##             main    #9517      +/-   ##
==========================================
- Coverage   58.56%   58.55%   -0.02%     
==========================================
  Files         226      226              
  Lines       14762    14765       +3     
  Branches     1256     1256              
==========================================
  Hits         8645     8645              
- Misses       6077     6080       +3     
  Partials       40       40              
Flag Coverage Δ
ws 54.30% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/ws/src/ws/WebSocketShard.ts 20.26% <0.00%> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@GrapeColor
Copy link
Contributor

GrapeColor commented May 5, 2023

It would be nice to be able to set the reconnection time as an option.😄

@didinele didinele force-pushed the fix/ws-reconnection-timeout branch from 80eec88 to 1a5d673 Compare May 5, 2023 20:02
@didinele
Copy link
Member Author

didinele commented May 5, 2023

It would be nice to be able to set the reconnection time as an option.😄

I don't see any case where that could ever be helpful

@kodiakhq kodiakhq bot merged commit 00da44a into main May 5, 2023
@kodiakhq kodiakhq bot deleted the fix/ws-reconnection-timeout branch May 5, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Infinite loop of WebSocket reconnection
5 participants