Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement GET current application #9797

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ❌ Failed (Inspect) Aug 25, 2023 9:29am
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 9:29am

@Jiralite Jiralite changed the title feat: implement current application route feat: Implement GET current application Aug 22, 2023
packages/core/src/api/index.ts Outdated Show resolved Hide resolved
packages/core/src/api/index.ts Outdated Show resolved Hide resolved
packages/core/src/api/application.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 22, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-feat-applications-get-discordjs.vercel.app/

Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #9797 (8f22903) into main (e3127a0) will increase coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9797      +/-   ##
==========================================
+ Coverage   59.82%   59.90%   +0.08%     
==========================================
  Files         234      234              
  Lines       15804    15781      -23     
  Branches     1196     1195       -1     
==========================================
  Hits         9454     9454              
+ Misses       6305     6282      -23     
  Partials       45       45              
Flag Coverage Δ
next ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit 50106c7 into main Aug 25, 2023
21 checks passed
@kodiakhq kodiakhq bot deleted the feat/applications-get branch August 25, 2023 09:33
almeidx pushed a commit to almeidx/discord.js that referenced this pull request Sep 24, 2023
* feat: implement current application route

* refactor: pluralisation

Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>

---------

Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants