Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BYOK for OSS storage driver #2791

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

denverdino
Copy link
Contributor

Merry Xmas!

Some enterprise customers require the BYOK(Bring Your Own Key) support for OSS storage driver.

The encryptionkeyid is added to the OSS driver configuration for KMS key id used for encryption

  oss:
    accesskeyid: accesskeyid
    accesskeysecret: accesskeysecret
    region: OSS region name
    endpoint: optional endpoints
    internal: optional internal endpoint
    bucket: OSS bucket
    encrypt: optional enable server-side encryption
    encryptionkeyid: optional KMS key id for encryption
    secure: optional ssl setting
    chunksize: optional size valye
    rootdirectory: optional root directory

And the Alibaba Cloud SDK is updated for new regions

Change-Id: I423ad03e63bd38aded3abfcba49079ff2fbb3b74
Signed-off-by: Li Yi <denverdino@gmail.com>
Change-Id: I195f29195f999e3e14ba921fd3435a6dc4788417
Signed-off-by: Li Yi <denverdino@gmail.com>
@codecov
Copy link

codecov bot commented Dec 25, 2018

Codecov Report

Merging #2791 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2791   +/-   ##
=======================================
  Coverage   60.24%   60.24%           
=======================================
  Files         103      103           
  Lines        8022     8022           
=======================================
  Hits         4833     4833           
  Misses       2546     2546           
  Partials      643      643
Flag Coverage Δ
#linux 60.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40b7b58...b783921. Read the comment docs.

Copy link
Collaborator

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan we good to merge?

@denverdino
Copy link
Contributor Author

@dmcgowan @caervs Can you help for merging the PR? Thanks a lot

1 similar comment
@denverdino
Copy link
Contributor Author

@dmcgowan @caervs Can you help for merging the PR? Thanks a lot

@dmcgowan dmcgowan merged commit b75069e into distribution:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants