Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix issue 20354: interface is not supported by cas #2853

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

lempiji
Copy link

@lempiji lempiji commented Nov 29, 2019

I want to fix this issue.
Some packages are breaking now. 😢

https://issues.dlang.org/show_bug.cgi?id=20354

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 29, 2019

Thanks for your pull request and interest in making D better, @lempiji! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20354 regression interface is not supported by CanCAS in core.internal.atomic

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + druntime#2853"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Nov 29, 2019
@thewilsonator
Copy link
Contributor

src\core\atomic.d(246): Error: undefined identifier `U`
src\core\atomic.d(830): Error: template instance `core.atomic.atomicExchange!(cast(MemoryOrder)5, Inter, shared(Inter))` error instantiating
src\core\atomic.d(910):        instantiated from here: `testXCHG!(shared(Inter))`

I think https://github.com/dlang/druntime/blob/master/src/core/atomic.d#L245-L246 is a typo.

CC @TurkeyMan git blames you for this

Should that be alias Thunk = Unshared!V;?

@thewilsonator
Copy link
Contributor

Also as this is a regression, please target stable.

Co-authored-by: ZombineDev <petar.p.kirov@gmail.com>
@PetarKirov
Copy link
Member

I rebased the PR to stable and fixed the remaining errors.
@TurkeyMan can you take another look?

@thewilsonator
Copy link
Contributor

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue
Projects
None yet
5 participants