-
-
Notifications
You must be signed in to change notification settings - Fork 426
Fix issue 20354: interface is not supported by cas #2853
Conversation
Thanks for your pull request and interest in making D better, @lempiji! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + druntime#2853" |
I think https://github.com/dlang/druntime/blob/master/src/core/atomic.d#L245-L246 is a typo. CC @TurkeyMan git blames you for this Should that be |
Also as this is a regression, please target stable. |
Co-authored-by: ZombineDev <petar.p.kirov@gmail.com>
I rebased the PR to stable and fixed the remaining errors. |
LGTM |
I want to fix this issue.
Some packages are breaking now. 😢
https://issues.dlang.org/show_bug.cgi?id=20354