-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning about the old std.json module from D1 #6111
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6111" |
I don't know about this. I know that people come into the Learn group and and are confused about the status of std.xml and want to know what to do. While these modules aren't fast or pretty, they do work while the linked modules do not. I don't think we should worry users about the stability of these modules when we don't have a road-map to replacing them. What we currently have are modules which might replace the Phobos versions if someone picks up the torch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we should just do this to prevent people wasting time pouring their energy into this module when it's slated to be replaced.
However, I really would prefer seeing concrete evidence that std.data.json
is on its way into Phobos, before putting up signs like this one. Is integration of std.data.json
into Phobos being actively worked on? If not, aren't we just setting ourselves up for bad rep with modules that are deprecated but year after year remain without replacement?
current standards. It will remain until we have a suitable replacement, | ||
but be aware that it will not remain long term. | ||
You can preview the future $(LINK2 https://github.com/s-ludwig/std_data_json, `std.data.json`). | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A mention of the upcoming package is worthwhile, but we do not lay judgment.
AFAIK Sönke has stopped working on |
Yeah, if nobody is actively working on |
BTW, I think we can fix this example by making JSONValue not use unions. It will use more memory, but it will be safe. I think that's more important for Phobos. |
b953a0c
to
9771b69
Compare
Folks, this is really simple. If we have a definite existing or upcoming replacement in the standard library, we can advertise it. If we invite others to work on one, that's nice to mention too. A "see also" section somewhere? Fine, too. Otherwise the standard library isn't in the business of passing judgment about itself. This is not open for negotiation. |
@wilzbach Adding a simple see also section to the top with a link to Sönke's library that states
seems like the best option here. |
We shouldn't advertise code like this:
https://run.dlang.io/is/KW86zH
https://dlang.org/phobos/std_json.html