Add hubspot properties #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steinitzu
force-pushed
the
add_hubspot_properties
branch
2 times, most recently
from
8004868
to
798bb1a
Compare
steinitzu
force-pushed
the
add_hubspot_properties
branch
from
21e8b82
to
dab40ce
Compare
rudolfix
requested changes
Jul 9, 2023
steinitzu
force-pushed
the
add_hubspot_properties
branch
from
d6f0464
to
125546b
Compare
|
@rudolfix added it to tests and demo. I don't think I have the right test account locally so I'm not checking the data very thoroughly for now. |
steinitzu
commented
Jul 15, 2023
| ) | ||
| # Get history separately, as requesting both all properties and history together | ||
| # is likely to hit hubspot's URL length limit | ||
| for history_entries in fetch_property_history( |
There was a problem hiding this comment.
Changed this too. With some endpoints the URL was too long when listing all properties twice. 😨
|
@steinitzu I sent you the credentials to test account. let's make sure that some proper test cases are there before merging. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tell us what you do here
Relevant issue
Implements #195
More PR info