Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated "full_refresh" with "dev_mode" #565

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

dat-a-man
Copy link
Collaborator

Tell us what you do here

  • implementing verified source (please link a relevant issue labeled as verified source)
  • fixing a bug (please link a relevant bug report)
  • improving, documenting, or customizing an existing source (please link an issue or describe below)
  • anything else (please link an issue or describe below)

Short description

Related Issues

  • Fixes #...
  • Closes #...
  • Resolves #...

Additional Context

@AstrakhantsevaAA
Copy link
Collaborator

You forgot about tests

@rudolfix
Copy link
Contributor

@AstrakhantsevaAA should we merge it? linter is passing. I think that is OK

@AstrakhantsevaAA
Copy link
Collaborator

@rudolfix @dat-a-man we should also update requirements imo, we have dlt>=0.3.25 for many of them and it won't work with these changes.

Copy link
Collaborator

@AstrakhantsevaAA AstrakhantsevaAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rudolfix can you merge it please?

@rudolfix rudolfix merged commit 35717f1 into master Oct 1, 2024
8 checks passed
@rudolfix rudolfix deleted the fix/deprecate_full_refresh branch October 1, 2024 08:59
neuromantik33 pushed a commit to neuromantik33/verified-sources that referenced this pull request Oct 5, 2024
* Deprecated "full_refresh" with "dev_mode"

* Updated

---------

Co-authored-by: rudolfix <rudolfix@rudolfix.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants