Skip to content

Commit

Permalink
Merge pull request kubernetes#25684 from kubernetes/revert-24852-fix-…
Browse files Browse the repository at this point in the history
…hyperkube-makefile

Automatic merge from submit-queue

Revert "OS X: Fix hyperkube build by adding empty string to sed invocation"

Reverts kubernetes#24852

This breaks the Linux build.

cc @johscheuer @zmerlynn
  • Loading branch information
k8s-merge-robot committed May 16, 2016
2 parents 835a257 + 57247a6 commit a6812d1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cluster/images/hyperkube/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,13 @@ endif

ifeq ($(ARCH),amd64)
# When building "normally" for amd64, remove the whole line, it has no part in the amd64 image
cd ${TEMP_DIR} && sed -i "" "/CROSS_BUILD_/d" Dockerfile
cd ${TEMP_DIR} && sed -i "/CROSS_BUILD_/d" Dockerfile
else
# When cross-building, only the placeholder "CROSS_BUILD_" should be removed
# Register /usr/bin/qemu-ARCH-static as the handler for ARM binaries in the kernel
docker run --rm --privileged multiarch/qemu-user-static:register --reset
curl -sSL --retry 5 https://github.com/multiarch/qemu-user-static/releases/download/v2.5.0/x86_64_qemu-${QEMUARCH}-static.tar.xz | tar -xJ -C ${TEMP_DIR}
cd ${TEMP_DIR} && sed -i "" "s/CROSS_BUILD_//g" Dockerfile
cd ${TEMP_DIR} && sed -i "s/CROSS_BUILD_//g" Dockerfile
endif

docker build -t ${REGISTRY}/hyperkube-${ARCH}:${VERSION} ${TEMP_DIR}
Expand Down

0 comments on commit a6812d1

Please sign in to comment.