Merge pull request #17 from dmccartney/daniel-manifest-fix

fix: prevent manifest not found errors in safe
dmccartney · Jun 9, 2023 · 046a0ed · 046a0ed
2 parents 858411e + 981972d
commit 046a0ed
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/web/public/index.html b/web/public/index.html
@@ -6,6 +6,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1" />
     <meta name="theme-color" content="#000000" />
     <link rel="icon shortcut" href="/favicon.ico"/>
+    <link rel="manifest" href="/manifest.json" />
     <title>Rocket Sweep - Distributing operator rewards for Rocket Pool</title>
 </head>
 <body>

diff --git a/web/src/components/SafeSweepCard.js b/web/src/components/SafeSweepCard.js
@@ -26,7 +26,7 @@ import {
 import _ from "lodash";
 import { useState } from "react";
 import { ethers } from "ethers";
-import { useAccount, useEnsName } from "wagmi";
+import { useAccount } from "wagmi";
 import SafeAppsSDK from "@safe-global/safe-apps-sdk";
 import {
   BNSortComparator,
@@ -222,8 +222,6 @@ function useSortedMinipoolDetails(nodeAddress) {
 }
 
 function SafeAlert({ sx, label, nodeAddress, safeAddress }) {
-  let { data: name } = useEnsName({ address: nodeAddress });
-  let nodeAddressOrName = name || nodeAddress;
   let { connector } = useAccount();
   if (connector?.id === "safe") {
     // No alert when it is already open as a Safe app.
@@ -232,7 +230,7 @@ function SafeAlert({ sx, label, nodeAddress, safeAddress }) {
   return (
     <Card sx={sx} elevation={8} square>
       <CardActionArea
-        href={safeAppUrl({ safeAddress, path: `/node/${nodeAddressOrName}` })}
+        href={safeAppUrl({ safeAddress })}
         target="_blank"
       >
         <CardHeader

diff --git a/web/src/utils.js b/web/src/utils.js
@@ -102,9 +102,11 @@ export function rocketscanUrl({ network = "mainnet", node, minipool }) {
 export function safeAppUrl({
   safeAddress,
   appUrl = process.env.REACT_APP_ROCKET_SWEEP_URL,
-  path = "",
 }) {
-  return `https://app.safe.global/apps/open?safe=eth:${safeAddress}&appUrl=${appUrl}${path}`;
+  const url = new URL(`https://app.safe.global/apps/open`)
+  url.searchParams.append('safe', `eth:${safeAddress}`)
+  url.searchParams.append('appUrl', appUrl)
+  return url.toString()
 }
 
 export function bnSum(arr) {