Skip to content
This repository has been archived by the owner on May 24, 2018. It is now read-only.

Use check than return false when parsing the config files. #112

Merged
merged 1 commit into from
Apr 27, 2015

Conversation

alaxwang
Copy link

Hi:
Happy to propose a code change. The motivation to modified the config.h is from my own use case.
When I wrote a config file for adding a conv layer, I used a chinese charater '=' instead of ascii '=' by accident, which was really hard to notice.
So the run.sh give a weird error msg like "kernel size exceed input error", I spend a lots of time to figure out why the kernel size exceed. And I found the config was using a chinese charater '=', which cause the config parse skip the all configs content followed the invalid string.
I think generally the parser should check the invalid config file instead of just skip it. It's more clear for user, not like me spend a lot of time to debug the tool for reasoning unmatched error message.

tqchen added a commit that referenced this pull request Apr 27, 2015
Use check than return false when parsing the config files.
@tqchen tqchen merged commit a4c4717 into dmlc:master Apr 27, 2015
@tqchen
Copy link
Member

tqchen commented Apr 27, 2015

Thanks for the PR, I agree that a more robust config parser is indeed needed and helpful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants