This repository has been archived by the owner on May 24, 2018. It is now read-only.
Use check than return false when parsing the config files. #112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi:
Happy to propose a code change. The motivation to modified the config.h is from my own use case.
When I wrote a config file for adding a conv layer, I used a chinese charater '=' instead of ascii '=' by accident, which was really hard to notice.
So the run.sh give a weird error msg like "kernel size exceed input error", I spend a lots of time to figure out why the kernel size exceed. And I found the config was using a chinese charater '=', which cause the config parse skip the all configs content followed the invalid string.
I think generally the parser should check the invalid config file instead of just skip it. It's more clear for user, not like me spend a lot of time to debug the tool for reasoning unmatched error message.