Refactor CMakeLists.txt #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes pslite as cmake target, to ease integration into upstream projects.
Current integration is done via a "parent scope hack", that is non-standard and actually removed by some people shipping ps-lite [1].
We require CMake 3.1 released Dec 17, 2014 as it is the first CMake release with proper C++11 support and as ps-lite uses C++11.
I tested the changes by building MXNet with
-DUSE_DIST_KVSTOREand the updated ps-lite. The following branch was built https://github.com/leezu/mxnet/commits/pslitecmakeupdateReferences:
[1] https://github.com/search?l=Diff&q=set%28pslite_LINKER_LIBS+%24%7Bpslite_LINKER_LIBS_L%7D%29&type=Code
CC @yajiedesign @eric-haibin-lin @szha