Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Downgrade libomp package to 11.1.0 #299

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Jul 15, 2021

https://app.travis-ci.com/github/dmlc/treelite/jobs/524580900#L3132:

tests/python/test_basic.py::test_basic[mushroom-True-None-True-gcc] 
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong
with the build itself.
Check the details on how to adjust your build configuration on:
https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I suspect it has to do with the use of OpenMP in src/annotator.cc.

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #299 (55e3e46) into mainline (b2f52bd) will increase coverage by 0.23%.
The diff coverage is n/a.

❗ Current head 55e3e46 differs from pull request most recent head 5a5577c. Consider uploading reports for the commit 5a5577c to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #299      +/-   ##
==============================================
+ Coverage       84.75%   84.98%   +0.23%     
  Complexity         46       46              
==============================================
  Files             104      106       +2     
  Lines            7019     8040    +1021     
  Branches           50      461     +411     
==============================================
+ Hits             5949     6833     +884     
- Misses           1045     1182     +137     
  Partials           25       25              
Impacted Files Coverage Δ
src/compiler/native/pred_transform.h 80.82% <0.00%> (-11.64%) ⬇️
include/treelite/frontend.h 90.00% <0.00%> (-10.00%) ⬇️
src/filesystem.cc 50.00% <0.00%> (-7.15%) ⬇️
src/gtil/pred_transform.cc 94.25% <0.00%> (-5.75%) ⬇️
include/treelite/predictor.h 70.73% <0.00%> (-5.03%) ⬇️
src/compiler/elf/elf_formatter.cc 96.07% <0.00%> (-3.93%) ⬇️
src/data.cc 80.76% <0.00%> (-3.51%) ⬇️
src/json_serializer.cc 92.17% <0.00%> (-2.33%) ⬇️
src/frontend/builder.cc 75.47% <0.00%> (-2.31%) ⬇️
src/frontend/lightgbm.cc 85.43% <0.00%> (-2.00%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2f52bd...5a5577c. Read the comment docs.

@hcho3 hcho3 changed the title [DO NOT MERGE] Debug a Python test that's hanging for 10 min. [CI] Downgrade libomp package to 11.1.0 Jul 15, 2021
@hcho3
Copy link
Collaborator Author

hcho3 commented Jul 15, 2021

Indeed, downgrading libomp to 11.1.0 fixes the tests. It's the same issue as dmlc/xgboost#7039. For now, downgrade libomp to 11.1.0 like dmlc/xgboost#7107.

@hcho3 hcho3 marked this pull request as ready for review July 15, 2021 18:21
@hcho3 hcho3 merged commit 59217af into dmlc:mainline Jul 15, 2021
@hcho3 hcho3 deleted the debug_openmp branch July 15, 2021 19:07
@hcho3 hcho3 mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant