Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basis of HAR translation #3

Merged
merged 7 commits into from
Apr 30, 2021
Merged

Add basis of HAR translation #3

merged 7 commits into from
Apr 30, 2021

Conversation

dnnrly
Copy link
Owner

@dnnrly dnnrly commented Apr 24, 2021

Description

This is the basic parsing and manipulation of HAR format data.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Running existing tests
  • Created new tests

Checklist:

  • My code has been linted (make lint)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have rebased my branch to include the latest changes from master

- This isn't necessary in most circumstances. And anyway, we can install it using `make deps` anyway
- This follows the standard package layout properly
@codecov
Copy link

codecov bot commented Apr 25, 2021

Codecov Report

Merging #3 (83f5907) into master (70e2491) will increase coverage by 100.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           master        #3        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%     
=============================================
  Files           0         2         +2     
  Lines           0        18        +18     
=============================================
+ Hits            0        18        +18     
Impacted Files Coverage Δ
har.go 100.00% <100.00%> (ø)
plantuml.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70e2491...83f5907. Read the comment docs.

@dnnrly dnnrly marked this pull request as ready for review April 30, 2021 20:37
@dnnrly dnnrly merged commit 63c4207 into master Apr 30, 2021
@dnnrly dnnrly deleted the feature/reading branch April 30, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant