Add support for corporate proxies #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I've also fixed a bug in delete_record.rb. Basically, change : record = Record.find(domain.name, id) to record = Record.find(domain, id) |
weppos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm working on a contract at a company behind a corporate proxy, so couldn't use your client ... but I've added support for it.
In the .dnsimple file, add these two optional settings :
proxy_addr: proxy.acmecorp.com
proxy_port: 8080
Those settings are then passed to httparty.
If the proxy settings are not present, things work as normal (ie as if there is no proxy)
Cheers,
Ben