Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates webflow configuration #101

Merged
merged 2 commits into from
May 18, 2020
Merged

Updates webflow configuration #101

merged 2 commits into from
May 18, 2020

Conversation

sbastn
Copy link
Member

@sbastn sbastn commented May 14, 2020

Fixes #94. This PR updates the one-click service for Webflow.

Based on their documentation https://university.webflow.com/article/connecting-a-custom-domain#update-the-dns, the one-click service has been updated to:

  1. Prompt for two A records
  2. Prompt for one CNAME record

👀 How to test this

  1. Checkout this branch.
  2. From the DNSimple app, point the services rake file to your local repo.
# File: lib/tasks/services.rake
5     sh("git clone /Users/me/projects/dnsimple/dnsimple-services tmp/dnsimple-services")
  1. From the DNSimple app, execute rake services:import
  2. From the DNSimple app, add the Webflow one-click service to any domain. You should be prompted to enter two A records for the root/apex, and a CNAME record that will be added to the "www" subdomain.
  3. On /services, you should see Webflow listed

Copy link
Member

@dallasread dallasread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Matches webflow documentation and creates expected records.

@sbastn sbastn requested a review from san983 May 14, 2020 16:42
Copy link
Member

@san983 san983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbastn sbastn merged commit 9cba14b into master May 18, 2020
@sbastn sbastn deleted the updates-webflow-configuration branch May 18, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webflow configuration is outdated
3 participants