Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Google copy and assets to reflect new name #109

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

deandre
Copy link
Contributor

@deandre deandre commented Jan 8, 2021

This change updates copy and assets to reflect Google Apps' new name, Google Workspace. This change was necessary to align with doc updates in dnsimple/dnsimple-support@4437ea2.

I think these changes are all that's necessary, but please lemme know if there's anything else to be done.

@sbastn
Copy link
Member

sbastn commented Jan 11, 2021

@deandre thanks for this PR. Unfortunately, we cannot rename services at the moment. There are 2 ways to proceed when a change like this is needed:

  • Keep the folder in place, and update the relevant fields along with the logo. We do this for rebrandings, so it would apply here.
  • Deprecate the service and create a new one. This would make sense if the DNS and the branding is completely different. Which is not the case here.

So you'll need to keep the google-apps folder in place. Here's what you can do:

  1. Inside the config.json, you can rename the following fields:
  • label

  • description

    The name will still have to be google-apps for now.

  1. You can update the instructions.md, the readme.md, and the logo.png.

I think this is a constraint that we can clarify in the readme of this repository. I'll be happy to do this.

sbastn
sbastn previously requested changes Jan 11, 2021
Copy link
Member

@sbastn sbastn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment with the requested changes

@deandre deandre requested a review from sbastn January 12, 2021 07:42
@deandre deandre dismissed sbastn’s stale review January 12, 2021 07:43

Thanks for the review, @sbastn. I committed new changes. Would you please take a look?

Copy link
Member

@sbastn sbastn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @deandre!

@deandre deandre merged commit f16bc7a into master Jan 13, 2021
@deandre deandre deleted the services/update-google branch January 13, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants