Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC-compliant SRV record content #172

Merged
merged 1 commit into from
Feb 16, 2023
Merged

RFC-compliant SRV record content #172

merged 1 commit into from
Feb 16, 2023

Conversation

jacegu
Copy link
Contributor

@jacegu jacegu commented Feb 15, 2023

This PR:

  • Updates the SRV records defined in 1 click services to include the final dot . (so called empty label according to RFC1035). The reason for this is that it is enforced by the record validations.
  • The affected services are:
    • Office 365
    • Fastmail

@jacegu jacegu self-assigned this Feb 15, 2023
sbastn
sbastn approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@sbastn sbastn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ggalmazor
ggalmazor approved these changes Feb 16, 2023
View reviewed changes
Copy link

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacegu jacegu merged commit b83f5b2 into main Feb 16, 2023
@jacegu jacegu deleted the bugfix/new-srv-format branch February 16, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbastn sbastn sbastn approved these changes

@ggalmazor ggalmazor ggalmazor approved these changes

@nestorsalceda nestorsalceda Awaiting requested review from nestorsalceda

Assignees

@jacegu jacegu

Labels
task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacegu @sbastn @ggalmazor