-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update both heroku to take randomly names #81
Conversation
Signed-off-by: Amelia Aronsohn <WagThatTail@Me.com>
@onlyhavecans do you have confirmation this change affects both SSL and non-SSL? |
No, and their support site does not help. Do we have a contact or test we can set up? |
You can probably setup a test app in our Heroku account, add a domain without SSL and see what they suggest to use as target hostname. |
@weppos and @onlyhavecans, I have simplified the setup, so instead of telling the user to manipulate the text to remove "herokudns.com" from it, they can just paste it all in since they have it in their clipboard. PreviouslyNow@weppos is correct, we cannot delete a one-click service, but you can deprecate it following this section on the README: https://github.com/dnsimple/dnsimple-services/#remove-services |
@sbastn can you please deprecate |
Signed-off-by: Amelia Aronsohn <WagThatTail@Me.com>
I deprecated the service per the docs and re-requested review. What is my deployment steps after approval? Can someone work with me to verify the deploy? |
@onlyhavecans the service repo is updated on deploy. So after a merge it's sufficient to deploy the app and the service changes will be loaded in the app. You will be able to confirm the changes are live by trying to apply the service and the new settings should appear. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 thanks @onlyhavecans
No description provided.