Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Squarespace configuration #88

Merged
merged 1 commit into from
Sep 24, 2019
Merged

Updates Squarespace configuration #88

merged 1 commit into from
Sep 24, 2019

Conversation

sbastn
Copy link
Member

@sbastn sbastn commented Sep 18, 2019

This PR fixes #87:

  1. Deprecates existing Squarespace6 configuration. We cannot change the name of a service, so this is why I am deprecating it.
  2. Adds new configuration for Squarespace.

🔍 Verification steps

  1. Point your local configuration to this branch. In your app, edit lib/tasks/services.rake to change the source where to load one-click services.
# sh("git clone git@github.com:dnsimple/dnsimple-services.git tmp/dnsimple-services")
sh("git clone ~/projects/dnsimple/dnsimple-services tmp/dnsimple-services")
  1. In the app, run the task rake services:load

  2. Verify that you see the service for Squarespace. Squarespace 6 shouldn't be visible.

Screen Shot 2019-09-18 at 12 27 18 PM

  1. Apply the service. It should create 3 records:

Screen Shot 2019-09-18 at 12 09 34 PM

  1. Verify that these are the expected records specified by Squarespace: https://support.squarespace.com/hc/en-us/articles/205812378

Copy link
Member

@san983 san983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

I was going to ask about the A records instead the ALIAS that appears in https://support.squarespace.com/hc/en-us/articles/205812378. But read about @OleMchls' test in #87 (comment) 👏

@sbastn sbastn merged commit fc02b08 into master Sep 24, 2019
@sbastn sbastn deleted the update-squarespace branch September 24, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Squarespace configuration
3 participants