Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch application from Parcel to Webpack #5

Merged
merged 9 commits into from
Mar 17, 2021
Merged

Switch application from Parcel to Webpack #5

merged 9 commits into from
Mar 17, 2021

Conversation

IAmJSD
Copy link
Contributor

@IAmJSD IAmJSD commented Feb 12, 2021

Type of Change

  • Build Scripts: Bump do-vue, make required local changes for webpack to work.

What issue does this relate to?

N/A

What should this PR do?

Build with Webpack.

What are the acceptance criteria?

Does the application build properly?

@MattIPv4 MattIPv4 marked this pull request as ready for review February 15, 2021 17:20
@MattIPv4 MattIPv4 self-requested a review February 15, 2021 17:21
MattIPv4
MattIPv4 reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary lgtm -- merge conflicts need resolving and packge.json needs pin removal once do-vue PR merged.

@IAmJSD IAmJSD merged commit aeaa88c into master Mar 17, 2021
@IAmJSD IAmJSD deleted the webpack branch March 17, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IAmJSD @MattIPv4