Shuffling around order so as to override default configure options. #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Since it is mostly a cosmetic change, I think we will wait for a version bump before we push new images to the hub. Though we'll definitely do a run of |
| @@ -71,6 +70,7 @@ RUN set -xe \ | |||
| --with-libedit \ | |||
| --with-openssl \ | |||
| --with-zlib \ | |||
| $PHP_EXTRA_CONFIGURE_ARGS \ | |||
There was a problem hiding this comment.
Can you replace the spaces with tabs like the surrounding block? 😉
There was a problem hiding this comment.
Sorry, force of habit! 😉
Fixed now!
…t configure options.
|
Awesome news, hopefully this'll go out in time for 7.0.9! Thanks both |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My specific use-case is one where I'm trying to run php-pm in a Docker container, however it has a hard dependency on CGI. Unfortunately
--enable-cgidoesn't work as an additional parameter in my Dockerfile, as the line immediately after it is--disable-cgi!