e2e: add new test package "global" with TestTLSVerify #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tibor Vass <tibor@docker.com>
tiborvass
force-pushed
the
test-tlsverify
branch
from
a005f3a
to
e692381
Compare
andrewhsu
approved these changes
Nov 12, 2019
thaJeztah
reviewed
Nov 12, 2019
|
|
||
| func TestTLSVerify(t *testing.T) { | ||
| // Remote daemons use TLS and this test is not applicable when TLS is required. | ||
| skip.If(t, environment.RemoteDaemon()) |
There was a problem hiding this comment.
Perhaps put the "skip" description as third argument to skip.If, then it shows up in the logs as reason why it's skipped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tibor Vass tibor@docker.com
This is to move TestRunTLSVerify from moby integration-cli tests.