Implemented dns_opt support (from api 1.21) #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, LGTM. |
|
+1 |
1 similar comment
|
👍 |
Signed-off-by: George Lester <glester491@gmail.com>
|
Rebased to handle merge conflict |
|
Is there a date when this might get merged? Not sure if there's like a "merge day" where PRs get pulled in, and I should have this rebased and ready to go. I don't remember to check the rebase status that often. |
|
Hey @Knetic , sorry for the lack of feedback - we usually wait for two maintainers to LGTM a PR before it gets merged, but with the summer months it's a bit difficult to get 2 pairs of eyes on everything. I've merged it now, since the changes are fairly low-risk and everything checks out. Thank you for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of making a PR for docker-compose to implement docker-compose:#3184, I realized the python client doesn't support
dns_opt. This should fix that.