-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix win32pipe.WaitNamedPipe throw exception in windows container #2421
Conversation
Please sign your commits following these rules: $ git clone -b "master" git@github.com:SLdragon/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f Amending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Renlong Tu <rentu@microsoft.com>
ping @shin- , please help approve this pull request, thank you very much! |
what is missing for this to be merged? |
Any update on when this can be merged? |
I have tested this PR in a Windows container with a small test environment from StefanScherer/dockerfiles-windows#432 and it works. Previously docker-compose just shows this error
Thanks for the contribution. Ping @chris-crone @ndeloof WDYT? Is the recursion ok here for max 10 iterations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @SLdragon and @StefanScherer !
Indeed, 10 iterations seems reasonable seeing what the code was before. Thanks! |
WaitNamedPipe API call in the npipesocket.py module doesn't work correctly from inside a Windows container.
This is because currently WaitNamedPipeis not supported from inside of Windows Containers (however CreateNamedPipeClient works ok). It fails with ERROR_FILE_NOT_FOUND
related issues:
#2018
docker/compose#5934
docker/for-win#4012
https://github.com/dotnet/corefx/issues/24594