Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to EE install for SLES #5097

Merged
merged 4 commits into from
Nov 6, 2017
Merged

Improvements to EE install for SLES #5097

merged 4 commits into from
Nov 6, 2017

Conversation

mdlinville
Copy link

@mdlinville mdlinville commented Oct 24, 2017

Copy link
Contributor

@gbarr01 gbarr01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 typo and a bunch of nits

- You do not have a separate `/var/` or `/var/lib/` or `/var/lib/docker/`
filesystem and `/` is not formatted with `btrfs`

If `/var/lib/docker` is apready a separate mount point and is not formatted
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already

with `btrfs`, back up its contents so that you can restore them after step
3.

2. Format your dedicated block device or devices as a Btrfs filesystem. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTRFS

@@ -85,7 +108,7 @@ BTRFS filesystem and mount it on `/var/lib/docker/`:
There are many more options for Btrfs, including striping and RAID. See the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTRFS

@@ -95,6 +118,9 @@ BTRFS filesystem and mount it on `/var/lib/docker/`:
Don't forget to make the change permanent across reboots by adding an
entry to `/etc/fstab`.

4. If `/var/lib/docker` previously existed and you backed up its contents
during step 1, restore them onto `/var/lib/docker`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restore it

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"contents" are plural so I think it is "them".

@@ -66,14 +68,35 @@ networks, are preserved. The Docker EE package is now called `docker-ee`.
## Configure the btrfs filesystem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTRFS

Copy link
Author

@mdlinville mdlinville Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? https://btrfs.wiki.kernel.org/index.php/Main_Page calls it Btrfs in the page and btrfs in the page title. I'm pretty OK with Btrfs -- if it is good enough for their docs, it's good enough for mine.

@mdlinville
Copy link
Author

Addressed feedback, thanks @gbarr01 🎁

@mdlinville mdlinville dismissed gbarr01’s stale review November 6, 2017 22:34

Addressed feedback

@mdlinville mdlinville merged commit 8aee9fe into docker:master Nov 6, 2017
@mdlinville mdlinville deleted the sles-improvements branch November 6, 2017 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants