-
Notifications
You must be signed in to change notification settings - Fork 7.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to EE install for SLES #5097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 typo and a bunch of nits
- You do not have a separate `/var/` or `/var/lib/` or `/var/lib/docker/` | ||
filesystem and `/` is not formatted with `btrfs` | ||
|
||
If `/var/lib/docker` is apready a separate mount point and is not formatted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
already
with `btrfs`, back up its contents so that you can restore them after step | ||
3. | ||
|
||
2. Format your dedicated block device or devices as a Btrfs filesystem. This |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTRFS
@@ -85,7 +108,7 @@ BTRFS filesystem and mount it on `/var/lib/docker/`: | |||
There are many more options for Btrfs, including striping and RAID. See the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTRFS
@@ -95,6 +118,9 @@ BTRFS filesystem and mount it on `/var/lib/docker/`: | |||
Don't forget to make the change permanent across reboots by adding an | |||
entry to `/etc/fstab`. | |||
|
|||
4. If `/var/lib/docker` previously existed and you backed up its contents | |||
during step 1, restore them onto `/var/lib/docker`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restore it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"contents" are plural so I think it is "them".
@@ -66,14 +68,35 @@ networks, are preserved. The Docker EE package is now called `docker-ee`. | |||
## Configure the btrfs filesystem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTRFS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? https://btrfs.wiki.kernel.org/index.php/Main_Page calls it Btrfs
in the page and btrfs
in the page title. I'm pretty OK with Btrfs -- if it is good enough for their docs, it's good enough for mine.
Addressed feedback, thanks @gbarr01 🎁 |
Fixes #5068
Fixes #5069
Fixes https://github.com/docker/orca/issues/9951
cc/ @briantd