Update work-with-networks.md #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corresponds to issue #34873: clarifies that the IP address used for binding should be an actual IP on the user's host, and not literally 172.23.0.1
mdlinville
approved these changes
Nov 9, 2017
|
See my edit to the description and also my edit to the commit message -- please don't mention issues or PRs by number in the commit message as this will ping the issue (or in this case, a hypothetical issue in THIS repo, since you didn't provide the full URL to the Moby issue) and possibly close issues in other repos, erroneously, each time the commit makes it into a new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to issue #34873: clarifies that the IP address used for binding should be an actual IP on the user's host, and not literally 172.23.0.1
Proposed changes
Edited the wording to clarify that the IP address used in
network createexample must be an IP address available on the user's host, and not literally 172.23.0.1.Related issues (optional)
Fixes moby/moby#34873