Added docker-client-swift #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlinville
suggested changes
Nov 13, 2017
| | PHP | [Docker-PHP](https://github.com/docker-php/docker-php) | | ||
| | Ruby | [docker-api](https://github.com/swipely/docker-api) | | ||
| | Rust | [docker-rust](https://github.com/abh1nav/docker-rust) | | ||
| | Rust | [shiplift](https://github.com/softprops/shiplift) | |
There was a problem hiding this comment.
You didn't introduce this but can you change the second Rust to Shoplift?
There was a problem hiding this comment.
I am not sure I understand, there’s no repo Shoplift, and neither shoplift nor shiplift are languages.
I rather stick with the changes related to docker-client-swift
There was a problem hiding this comment.
Sorry, Shiplift. Line 273. My hypothesis is that it was copy-pasted from line 272 and the person forgot to change the first column.
There was a problem hiding this comment.
I think that's right though. Rust is the language.
mdlinville
approved these changes
Nov 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docker-client-swift