This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Add a Machine Readable State for container #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See moby/moby#18966 Signed-off-by: Vincent Demeester <vincent@sbr.pm>
|
|
|
@mariusGundersen damn you're right.. did write it too quick 😝 |
vdemeester
changed the title
| @@ -142,6 +142,7 @@ type Container struct { | |||
| SizeRw int64 `json:",omitempty"` | |||
| SizeRootFs int64 `json:",omitempty"` | |||
| Labels map[string]string | |||
| State string | |||
| Status string | |||
There was a problem hiding this comment.
In moby/moby#18966 code or doc, the order is State after Status.
Status string
+ State string
There was a problem hiding this comment.
true 😝 But I thought it made more sense to make it alphabetically (but Labels is not so... meh.. 😃)
|
LGTM. |
|
LGTM |
calavera
added a commit
that referenced
this pull request
Jan 15, 2016
Add a Machine Readable State for container
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See moby/moby#18966
/cc @calavera @MHBauer
Signed-off-by: Vincent Demeester vincent@sbr.pm