Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always set buildkitd-flags if opt-in #363

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Oct 2, 2024

follow-up #357 (comment)

We should always pass buildkitd-flags if user opt-in for it and let the driver handle it. We just need to make sure the driver supports buildkitd-flags if the input is not set to pass defaults.

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make sure that the docs mention that if user sets buildkitd-flags then the default is reset, and user might want to make sure set default again if they want that behavior.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

@tonistiigi Done

@crazy-max crazy-max merged commit 5334dd0 into docker:master Oct 3, 2024
43 checks passed
@crazy-max crazy-max deleted the set-buildkitd-flags-optin branch October 3, 2024 07:14
@twelho
Copy link

twelho commented Oct 11, 2024

From what I can tell, this prevents clearing of buildkitd-flags if the user does not want the default insecure entitlement flags. Setting something like

- uses: docker/setup-buildx-action@v3
  with:
    buildkitd-flags: ""

or any other falsy value will get disregarded, and the insecure entitlement flags will always get applied, which is unwanted in some situations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants