npm audit fixes #1077
Merged
npm audit fixes #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NatalieEO
requested review from
garyluu,
chmreid,
coverbeck,
david4096 and
denis-yuen
Codecov Report
@@ Coverage Diff @@
## develop #1077 +/- ##
===========================================
+ Coverage 49.56% 49.57% +0.01%
===========================================
Files 296 292 -4
Lines 12618 12447 -171
Branches 2708 2674 -34
===========================================
- Hits 6254 6171 -83
+ Misses 4011 3956 -55
+ Partials 2353 2320 -33
Continue to review full report at Codecov.
|
coverbeck
approved these changes
Sep 23, 2020
| @@ -48,18 +48,20 @@ | |||
| (descriptorType$ | async) === ToolDescriptor.TypeEnum.CWL && | |||
| (workflow$ | async)?.source_control_provider === 'GITHUB' | |||
| " | |||
| style="line-height: 20px;" | |||
| style="line-height: 20px" | |||
There was a problem hiding this comment.
Did prettifier do this? I always thought the semi-colon was proper, although browsers would typically let you get away without it. MDN example has semi-colon.
There was a problem hiding this comment.
yeah, it's getting changed when I make a commit.
There was a problem hiding this comment.
Looked deeper and I was wrong. CSS spec doesn't have a trailing semi-colon.
denis-yuen
approved these changes
Sep 23, 2020
garyluu
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ucsc-cgl.atlassian.net/browse/SEAB-1402
Removed pipeline-builder because of epam/pipeline-builder#57 and it doesn't handle WDL 1.0. Commented out wdl-viewer.
Used Gary's suggestion in his comment for rc because it needs to update minimist dominictarr/rc#113