Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update streamlit version plus improvements to API need by Chrome Ext #268

Merged
merged 37 commits into from
Sep 7, 2024

Conversation

janaka
Copy link
Contributor

@janaka janaka commented Sep 7, 2024

Description

Please include a summary of the change, e.g. what the new feature # is and/or what bug # it fixes. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes/Implements #(issue/feature)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

this changes how menu nav is handled.
fix: model select st.selectbox
add ability to add sidebar elements above the logout button from anywhere rather than do a CSS fiddle.
refactor(WebAPI): as models to handle single ThreadModel responses rather than returning a list.

refactor(WebAPI): adjust model class naming to improve consistency of naming conventions
Pydantic validation error because didn't realise pydantic validsation run on the constructor by default
…o sets serialization alias to camel case.

adjust API response serialization to use the camel case serialization alias
@janaka janaka requested a review from a team as a code owner September 7, 2024 17:12
@janaka janaka merged commit 2e81525 into main Sep 7, 2024
1 check passed
@janaka janaka deleted the build/update-streamlit-package branch September 7, 2024 17:21
@janaka janaka linked an issue Sep 7, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streamlit v1.38 update related fixes
1 participant