-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ux/consolidate space mgmt #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
@osala-eng I added a comment to the issue re: naming the new section "Admin Spaces" |
* feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Add custom styling for personal ask. * chore: Remove unused imports. * Refactor: azureblob datasource (#79) refactor: Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL * docs: update AzureBlobs to match refactor * Update `aiohttp` from 3.8.4 -> 3.8.5 * Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper * refactor: move document list management methods to `SpaceDataSourceFileBased` * add OpendalReader code + lic + copyright * refactor: DocumentListItem * change from `tuple` to a `dataclass` * move to domain.py * chore: remove commented code * test: * unit test DocumentListItem.create_instance * unit test consistency between document list save and load (serialise and de-serialise). * move test PDF doc folder * Various minor fixes: * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text. * pass args to DocumentListItem() in the correct order * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index. * style: fix style and lint errors BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working. * chore: Add avatar to chat messages * chore: Added script to format avartars. * feat: Make the space selector box stick to the top of the page. * chore: Remove unused imports. * Update user avatar settings. * chore: Attach event listeners to space selector. * chore: Cleanup imports. * chore: Update chat_ui script. * feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Use username as email for gravatar requests. * chore: Use identicon as avatar default * chore: Set username in auth session state. * chore: Cleanup imports. * chore: Bump llama-index to 0.8.5.post2 * Update get username function --------- Co-authored-by: Janaka Abeywardhana <contact@janaka.co.uk>
janaka
reviewed
Aug 25, 2023
janaka
reviewed
Aug 25, 2023
janaka
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments
Issue #64 - Expose creating a new thread in the UI (effectively clearing history). - Add backend functionality to save chat history grouped by a thread_id. - UI to switch between threads will be added as a separate feature.
* feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Add custom styling for personal ask. * chore: Remove unused imports. * Refactor: azureblob datasource (#79) refactor: Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL * docs: update AzureBlobs to match refactor * Update `aiohttp` from 3.8.4 -> 3.8.5 * Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper * refactor: move document list management methods to `SpaceDataSourceFileBased` * add OpendalReader code + lic + copyright * refactor: DocumentListItem * change from `tuple` to a `dataclass` * move to domain.py * chore: remove commented code * test: * unit test DocumentListItem.create_instance * unit test consistency between document list save and load (serialise and de-serialise). * move test PDF doc folder * Various minor fixes: * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text. * pass args to DocumentListItem() in the correct order * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index. * style: fix style and lint errors BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working. * chore: Add avatar to chat messages * chore: Added script to format avartars. * feat: Make the space selector box stick to the top of the page. * chore: Remove unused imports. * Update user avatar settings. * chore: Attach event listeners to space selector. * chore: Cleanup imports. * chore: Update chat_ui script. * feat: Make the space selector box stick to the top of the page. * chore: Cleanup files. * chore: Use username as email for gravatar requests. * chore: Use identicon as avatar default * chore: Set username in auth session state. * chore: Cleanup imports. * chore: Bump llama-index to 0.8.5.post2 * Update get username function --------- Co-authored-by: Janaka Abeywardhana <contact@janaka.co.uk>
Issue #64 - Expose creating a new thread in the UI (effectively clearing history). - Add backend functionality to save chat history grouped by a thread_id. - UI to switch between threads will be added as a separate feature.
janaka
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #52
Updated admin docs ui layout
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.
Test Configuration:
Please describe the test setup. List them below as bullet points.
Checklist: