Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ux/consolidate space mgmt #89

Merged
merged 15 commits into from
Sep 4, 2023
Merged

Ux/consolidate space mgmt #89

merged 15 commits into from
Sep 4, 2023

Conversation

osala-eng
Copy link
Contributor

@osala-eng osala-eng commented Aug 21, 2023

Description

Implements #52

Updated admin docs ui layout
admin_docs

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor and code improvement (non-breaking change which improves code quality and/or performance)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Tests
  • Other chores such as maintenance

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration by modifying the list below.

  • Test A
  • Test B
  • Test C

Test Configuration:

Please describe the test setup. List them below as bullet points.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • The commit message follows the convention of this project

@osala-eng osala-eng linked an issue Aug 21, 2023 that may be closed by this pull request
2 tasks
@janaka
Copy link
Contributor

janaka commented Aug 21, 2023

@osala-eng I added a comment to the issue re: naming the new section "Admin Spaces"

osala-eng and others added 3 commits August 22, 2023 12:03
* feat: Make the space selector box stick to the top of the page.

* chore: Cleanup files.

* chore: Add custom styling for personal ask.

* chore: Remove unused imports.

* Refactor: azureblob datasource (#79)

refactor:  Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL

* docs: update AzureBlobs to match refactor
* Update `aiohttp` from 3.8.4 -> 3.8.5
* Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper
* refactor: move document list management methods to `SpaceDataSourceFileBased`
* add OpendalReader code + lic + copyright 

* refactor: DocumentListItem
  * change from `tuple` to a `dataclass`
  * move to domain.py
* chore: remove commented code
* test:
  * unit test DocumentListItem.create_instance
  * unit test consistency between document list save and load (serialise and de-serialise).
  * move test PDF doc folder
* Various minor fixes:
   * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text.
  * pass args to DocumentListItem() in the correct order
  * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index.
  * style: fix style and lint errors 

BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working.

* chore: Add avatar to chat messages

* chore: Added script to format avartars.

* feat: Make the space selector box stick to the top of the page.

* chore: Remove unused imports.

* Update user avatar settings.

* chore: Attach event listeners to space selector.

* chore: Cleanup imports.

* chore: Update chat_ui script.

* feat: Make the space selector box stick to the top of the page.

* chore: Cleanup files.

* chore: Use username as email for gravatar requests.

* chore: Use identicon as avatar default

* chore: Set username in auth session state.

* chore: Cleanup imports.

* chore: Bump llama-index to 0.8.5.post2

* Update get username function

---------

Co-authored-by: Janaka Abeywardhana <contact@janaka.co.uk>
@osala-eng
Copy link
Contributor Author

Renamed consolidated space to Admin Docs

image

@osala-eng osala-eng marked this pull request as ready for review August 22, 2023 09:15
@osala-eng osala-eng requested a review from a team as a code owner August 22, 2023 09:15
web/utils/layout.py Outdated Show resolved Hide resolved
Copy link
Contributor

@janaka janaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

janaka and others added 7 commits August 25, 2023 17:45
Issue #64 
- Expose creating a new thread in the UI (effectively clearing history).
- Add backend functionality to save chat history grouped by a thread_id.
- UI to switch between threads will be added as a separate feature.
* feat: Make the space selector box stick to the top of the page.

* chore: Cleanup files.

* chore: Add custom styling for personal ask.

* chore: Remove unused imports.

* Refactor: azureblob datasource (#79)

refactor:  Azure Blob data source - Switch data loader to our custom implementation based on OpenDAL

* docs: update AzureBlobs to match refactor
* Update `aiohttp` from 3.8.4 -> 3.8.5
* Change document file list to read from local json file (same as web scraper) rather than direct from Azure. Similar to web scraper
* refactor: move document list management methods to `SpaceDataSourceFileBased`
* add OpendalReader code + lic + copyright

* refactor: DocumentListItem
  * change from `tuple` to a `dataclass`
  * move to domain.py
* chore: remove commented code
* test:
  * unit test DocumentListItem.create_instance
  * unit test consistency between document list save and load (serialise and de-serialise).
  * move test PDF doc folder
* Various minor fixes:
   * Always have some text for `page_title` metadata to render a link. Improve default behaviour to use <title> text if no H1. "web page" if no title text.
  * pass args to DocumentListItem() in the correct order
  * handle unknown source type in metadata. This should only happen if a breaking change to the type schema is made and data isn't migrated i.e. re-index.
  * style: fix style and lint errors

BREAKING CHANGE: Azure Blob data source config scheme for credentials changes. SAS tokens are no longer supported only Account Key. Any Azure Blob data sources configured with a SAS token will stop working.

* chore: Add avatar to chat messages

* chore: Added script to format avartars.

* feat: Make the space selector box stick to the top of the page.

* chore: Remove unused imports.

* Update user avatar settings.

* chore: Attach event listeners to space selector.

* chore: Cleanup imports.

* chore: Update chat_ui script.

* feat: Make the space selector box stick to the top of the page.

* chore: Cleanup files.

* chore: Use username as email for gravatar requests.

* chore: Use identicon as avatar default

* chore: Set username in auth session state.

* chore: Cleanup imports.

* chore: Bump llama-index to 0.8.5.post2

* Update get username function

---------

Co-authored-by: Janaka Abeywardhana <contact@janaka.co.uk>
Issue #64
- Expose creating a new thread in the UI (effectively clearing history).
- Add backend functionality to save chat history grouped by a thread_id.
- UI to switch between threads will be added as a separate feature.
@osala-eng
Copy link
Contributor Author

Left a few comments

I've rebased this branch

I rearranged the Load chat history and New Chat buttons to be on a single collumn, hope that's okay.

image

@osala-eng osala-eng merged commit 5048f66 into main Sep 4, 2023
3 checks passed
@osala-eng osala-eng deleted the ux/consolidate-space-mgmt branch September 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Consolidate Space management into a single view
2 participants