Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poor embed load performance (loaded serially, should be in parallel) #525

Closed
jhildenbiddle opened this issue Jun 7, 2018 · 1 comment
Closed

Poor embed load performance (loaded serially, should be in parallel) #525

jhildenbiddle opened this issue Jun 7, 2018 · 1 comment

Comments

@jhildenbiddle
Copy link
Member

jhildenbiddle commented Jun 7, 2018 •
edited
Loading

Docsify embeds are loaded serially instead of in parallel. This has a significant performance impact on pages that have more than one embed.

Take the Customization page of the docsify-themeable site as an example.

screen shot 2018-06-06 at 9 48 12 pm

This page loads ten separate embeds for a combined total of roughly 12k. Despite the light payload, the embeds take six seconds to load as a result of loading them serially. Load performance would be dramatically improved if these files were loaded in parallel.
@jhildenbiddle jhildenbiddle mentioned this issue Jun 7, 2018
Closed
QingWei-Li added a commit that referenced this issue Jun 19, 2018
@QingWei-Li
fix: loading embed files synchronously, fixed #525, fixed #527
938ecd5
@jhildenbiddle
Copy link
Member Author

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhildenbiddle