Fix nested toc style issue on sidebar #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Remove recursive toc outer tag li 2. remove .sidebar li marginLeft 3. add .sidebar ul marginLeft
|
I haven't tested the PR, but if this fixes the inconsistent nesting then I'm all for it! Thanks, @keelii. Looking forward to this being merged. |
|
The issue haven't been fixed. How to solve it? @keelii Thanks! |
|
@ThomsonTang This PR has being merged, just waiting for next release or you can read Files change fix it by yourself. |
|
@keelii I change the files on my local machine about this PR then that's all right. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to fix nested toc style issue below.
Before
After
Here is my solution.
li.sidebar limarginLeft.sidebar ulmarginLeftRelated issue:
#421
#519