Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zoom-image target elements #640

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix zoom-image target elements #640

merged 1 commit into from
Oct 23, 2018

Conversation

jhildenbiddle
Copy link
Member

  • Ignore images outside of main content area (e.g. logo, sidenav icons, etc.)
  • Ignore linked images (previous behavior broke linked images)

Fixes #520

  • [ x ] Make sure you are merging your commits to master branch.
  • [ x ] Add some descriptions and refer relative issues for you PR.
  • [ x ] DO NOT include files inside lib directory.

@jhildenbiddle
Fix zoom-image target elements
85fcb3f 
- Ignore images outside of main content area (e.g. logo, sidenav icons, etc.)
- Ignore linked images (previous behavior broke linked images)

Fixes #520
@QingWei-Li QingWei-Li merged commit 63876c6 into docsifyjs:master Oct 23, 2018
@jhildenbiddle jhildenbiddle deleted the fix/520 branch January 17, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhildenbiddle @QingWei-Li