Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unexpected 404 #668

Merged
merged 1 commit into from
Nov 1, 2018
Merged

fix: unexpected 404 #668

merged 1 commit into from
Nov 1, 2018

Conversation

cheng-kang
Copy link
Contributor

Closes #664

Issue

prerenderEmbed is using the actual cached value when there is a hit. The value (an array) gets cleared somehow during processing https://github.com/docsifyjs/docsify/blob/master/src/core/render/index.js#L159. By the time the cached value is hit again, though the value is not undefined, the content is empty. Hence 404 shows up.

Solution

Using a copy of cached value solves the problem.


Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you are merging your commits to master branch.
  • Add some descriptions and refer relative issues for you PR.
  • DO NOT include files inside lib directory.

@cheng-kang cheng-kang changed the title Fix #664 fix: unexpected 404 Oct 31, 2018
@QingWei-Li QingWei-Li merged commit 5fcf210 into master Nov 1, 2018
@QingWei-Li QingWei-Li deleted the fix/664 branch November 1, 2018 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants