Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ResolveTargetEntityListener #72

Merged
merged 2 commits into from
May 14, 2012
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion DependencyInjection/Configuration.php
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,8 @@ private function addOrmSection(ArrayNodeDefinition $node)
// Key that should not be rewritten to the connection config
$excludedKeys = array(
'default_entity_manager' => true, 'auto_generate_proxy_classes' => true,
'proxy_dir' => true, 'proxy_namespace' => true,
'proxy_dir' => true, 'proxy_namespace' => true, 'resolve_target_entities' => true,
'resolve_target_entity' => true,
);
$entityManager = array();
foreach ($v as $key => $value) {
Expand All @@ -238,11 +239,28 @@ private function addOrmSection(ArrayNodeDefinition $node)
->end()
->fixXmlConfig('entity_manager')
->append($this->getOrmEntityManagersNode())
->fixXmlConfig('resolve_target_entity', 'resolve_target_entities')
->append($this->getOrmTargetEntityResolverNode())
->end()
->end()
;
}

private function getOrmTargetEntityResolverNode()
{
$treeBuilder = new TreeBuilder();
$node = $treeBuilder->root('resolve_target_entities');

$node
->useAttributeAsKey('interface')
->prototype('scalar')
->cannotBeEmpty()
->end()
;

return $node;
}

private function getOrmEntityManagersNode()
{
$treeBuilder = new TreeBuilder();
Expand Down
11 changes: 11 additions & 0 deletions DependencyInjection/DoctrineExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,17 @@ protected function ormLoad(array $config, ContainerBuilder $container)
$entityManager['name'] = $name;
$this->loadOrmEntityManager($entityManager, $container);
}

if ($config['resolve_target_entities']) {
$def = $container->findDefinition('doctrine.orm.listeners.resolve_target_entity');
foreach ($config['resolve_target_entities'] as $name => $implementation) {
$def->addMethodCall('addResolveTargetEntity', array(
$name, $implementation, array()
));
}

$def->addTag('doctrine.event_listener', array('event' => 'loadClassMetadata'));
}
}

/**
Expand Down
6 changes: 6 additions & 0 deletions Resources/config/orm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@

<!-- security -->
<parameter key="doctrine.orm.security.user.provider.class">Symfony\Bridge\Doctrine\Security\User\EntityUserProvider</parameter>

<!-- listeners -->
<parameter key="doctrine.orm.listeners.resolve_target_entity.class">Doctrine\ORM\Tools\ResolveTargetEntityListener</parameter>
</parameters>

<services>
Expand Down Expand Up @@ -87,5 +90,8 @@
<service id="doctrine.orm.security.user.provider" class="%doctrine.orm.security.user.provider.class%" abstract="true" public="false">
<argument type="service" id="doctrine" />
</service>

<!-- listeners -->
<service id="doctrine.orm.listeners.resolve_target_entity" class="%doctrine.orm.listeners.resolve_target_entity.class%" public="false" />
</services>
</container>
9 changes: 9 additions & 0 deletions Resources/config/schema/doctrine-1.0.xsd
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
<xsd:element name="metadata-cache-driver" type="metadata_cache_driver" minOccurs="0" maxOccurs="1" />
<xsd:element name="dql" type="dql" minOccurs="0" maxOccurs="1" />
<xsd:element name="filter" type="filter" minOccurs="0" maxOccurs="unbounded" />
<xsd:element name="resolve-target-entity" type="resolve_target_entity" minOccurs="0" maxOccurs="unbounded" />
</xsd:choice>

<xsd:attribute name="auto-mapping" type="xsd:string" />
Expand All @@ -125,6 +126,14 @@
<xsd:attribute name="query-cache-driver" type="xsd:string" />
</xsd:complexType>

<xsd:complexType name="resolve_target_entity">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use dashed in XML to be consistent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, forget it as it is the type, not the tag name

<xsd:simpleContent>
<xsd:extension base="xsd:string">
<xsd:attribute name="interface" type="xsd:string" use="required" />
</xsd:extension>
</xsd:simpleContent>
</xsd:complexType>

<xsd:complexType name="metadata_cache_driver">
<xsd:all>
<xsd:element name="class" type="xsd:string" minOccurs="0" maxOccurs="1" />
Expand Down
1 change: 1 addition & 0 deletions Tests/ContainerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ protected function setUp()
public function testContainer()
{
$container = $this->createYamlBundleTestContainer();

$this->assertInstanceOf('Symfony\Bridge\Doctrine\Logger\DbalLogger', $container->get('doctrine.dbal.logger'));
$this->assertInstanceOf('Symfony\Bridge\Doctrine\DataCollector\DoctrineDataCollector', $container->get('data_collector.doctrine'));
$this->assertInstanceOf('Doctrine\DBAL\Configuration', $container->get('doctrine.dbal.default_connection.configuration'));
Expand Down
16 changes: 16 additions & 0 deletions Tests/DependencyInjection/AbstractDoctrineExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,7 @@ public function testAddFilter()

$loader = new DoctrineExtension();
$container->registerExtension($loader);

$this->loadFromFile($container, 'orm_filters');
$this->compileContainer($container);

Expand All @@ -748,6 +749,21 @@ public function testAddFilter()
$this->assertCount(1, $entityManager->getFilters()->getEnabledFilters());
}

public function testResolveTargetEntity()
{
$container = $this->getContainer(array('YamlBundle'));

$loader = new DoctrineExtension();
$container->registerExtension($loader);

$this->loadFromFile($container, 'orm_resolve_target_entity');
$this->compileContainer($container);

$definition = $container->getDefinition('doctrine.orm.listeners.resolve_target_entity');
$this->assertDICDefinitionMethodCallOnce($definition, 'addResolveTargetEntity', array('Symfony\Component\Security\Core\User\UserInterface', 'MyUserClass', array()));
$this->assertEquals(array('doctrine.event_listener' => array( array('event' => 'loadClassMetadata') ) ), $definition->getTags());
}

protected function getContainer($bundles = 'YamlBundle', $vendor = null)
{
$bundles = (array) $bundles;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?xml version="1.0" ?>

<srv:container xmlns="http://symfony.com/schema/dic/doctrine"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xmlns:srv="http://symfony.com/schema/dic/services"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd
http://symfony.com/schema/dic/doctrine http://symfony.com/schema/dic/doctrine/doctrine-1.0.xsd">

<config>
<dbal default-connection="default">
<connection name="default" dbname="db" />
</dbal>

<orm default-entity-manager="default">
<resolve-target-entity interface="Symfony\Component\Security\Core\User\UserInterface">MyUserClass</resolve-target-entity>
</orm>
</config>
</srv:container>
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
doctrine:
dbal:
default_connection: default
connections:
default:
dbname: db

orm:
resolve_target_entities:
Symfony\Component\Security\Core\User\UserInterface: MyUserClass
11 changes: 8 additions & 3 deletions Tests/TestCase.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,12 @@
namespace Doctrine\Bundle\DoctrineBundle\Tests;

use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Bundle\DoctrineBundle\DependencyInjection\DoctrineExtension;

use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
use Doctrine\Bundle\DoctrineBundle\DependencyInjection\DoctrineExtension;
use Symfony\Component\DependencyInjection\Compiler\ResolveDefinitionTemplatesPass;
use Symfony\Bridge\Doctrine\DependencyInjection\CompilerPass\RegisterEventListenersAndSubscribersPass;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems unused


class TestCase extends \PHPUnit_Framework_TestCase
{
Expand Down Expand Up @@ -63,8 +65,11 @@ public function createYamlBundleTestContainer()
'dir' => __DIR__.'/DependencyInjection/Fixtures/Bundles/YamlBundle/Resources/config/doctrine',
'prefix' => 'Fixtures\Bundles\YamlBundle\Entity',
)
)
)))
))),
'resolve_target_entities' => array(
'Symfony\Component\Security\Core\User\UserInterface' => 'stdClass',
),
)
)), $container);

$container->setDefinition('my.platform', new \Symfony\Component\DependencyInjection\Definition('Doctrine\DBAL\Platforms\MySqlPlatform'));
Expand Down