Add compiler pass for bundles to register mappings #185
Conversation
| public static function createAnnotationMappingDriver(array $namespaces, array $directories, $enabledParameter = false) | ||
| { | ||
| $arguments = array(new Reference('doctrine_mongodb.odm.metadata.annotation_reader'), $directories); | ||
| $locator = new Definition('Doctrine\Common\Persistence\Mapping\Driver\SymfonyFileLocator', $arguments); |
There was a problem hiding this comment.
This is wrong (same than in the doctrineBundle)
|
StaticPHPDriver should also be supported (the whole driver lives in Common. The ORM only has a BC child class with no extra logic in it) |
|
Cross-referencing with the DoctrineBundle PR: doctrine/DoctrineBundle#177 |
|
i added support for php and staticphp drivers now by copying the definition creation code - its too small to make it worth to abstract it. this PR is now at the same state as the one on doctrine orm |
|
the doc PR about this is now merged: symfony/symfony-docs#2507 in doctrine/DoctrineBundle#177 i don't know if anything is still open or if its just not merged yet. tried to get the attention of stof and beberlei several times but they seem busy. |
|
doctrine orm is now merged too. anything left to do here? |
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Doctrine Bundle |
|
fixed the doc issue stof noticed, removed unnecessary |
| * @param bool $enabledParameter if specified, the compiler pass only | ||
| * executes if this parameter exists in the service container. | ||
| */ | ||
| public function __construct($driver, $namespaces, $managerParameters, $enabledParameter = false) |
There was a problem hiding this comment.
I think $namespaces and $managerParameters should be type-hinted, as in https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/DependencyInjection/CompilerPass/RegisterMappingsPass.php#L83
|
great, thanks a lot. |
jmikola
changed the title
use the compiler pass added to the doctrine bridge to provide a nice compiler pass for bundles. See symfony/symfony#7599 and doctrine/DoctrineBundle#177
documentation PR is at symfony/symfony-docs#2507
this is used for example in FriendsOfSymfony/FOSUserBundle#1081