Update configuration for 1.4.x driver options #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed VariableNode to prototyped ArrayNode Listing all options for connection in Configuration Removed \MongoClient consts Changed readPreferenceTags to arrayNode
This was referenced Feb 4, 2014
Closed
| ->end() | ||
| ->end() | ||
| ->booleanNode('j')->end() | ||
| ->scalarNode('timeout')->end() |
There was a problem hiding this comment.
shouldn't this be an integer node ?
There was a problem hiding this comment.
The bundle still supports Symfony 2.1, so those aren't yet available. Perhaps we can bump it to 2.2 for 3.0. I've created #220 to track the idea.
Also refactors the ConfigurationTest class. Removed strict checking of default_commit_options (and tests), added missing options. Fixed handling of readPreferenceTags option for XML. As a change, "server" and "options" no longer have default values; however, existing code in Configuration should handle this fine.
This is currently supported in AbstractDoctrineExtension.
jmikola
added a commit
that referenced
this pull request
Feb 4, 2014
Update configuration for 1.4.x driver options
|
Glad I could help :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes @malarzm's work in #218.
Fixes #203, #214, and #215.