Unset username and password options when null #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unset($v['password']); | ||
|
|
||
| return $v; | ||
| }) |
There was a problem hiding this comment.
it must be a separate ->validate() block, otherwise you will replace the previous conditions
| @@ -233,6 +233,13 @@ private function addConnectionsSection(ArrayNodeDefinition $rootNode) | |||
|
|
|||
| return $v; | |||
| }) | |||
| ->ifTrue(function($v) { return null === $v['username'] || null === $v['password']; }) | |||
There was a problem hiding this comment.
What was wrong with adding ->ifNull()->thenUnset() to the username and password scalar node definitions? If the user actually provides a username and leaves password null, I think we should send that directly to the driver rather than strip both values.
jmikola
changed the title
jmikola
added a commit
that referenced
this pull request
May 19, 2014
cordoval
deleted the
243-passing-null-values-as-username-password-option-causes-authentication-to-occur-and-fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #243
sent using Gush