Annotation driver mapping pass isn't correctly instantiated #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $arguments = array(new Reference('doctrine_mongodb.odm.metadata.annotation_reader'), $directories); | ||
| $locator = new Definition('Doctrine\Common\Persistence\Mapping\Driver\SymfonyFileLocator', $arguments); | ||
| $driver = new Definition('Doctrine\ODM\MongoDB\Mapping\Driver\AnnotationDriver', array($locator)); | ||
| $driver = new Definition('Doctrine\ODM\MongoDB\Mapping\Driver\AnnotationDriver', array(new Reference('doctrine_mongodb.odm.metadata.annotation_reader'), $directories)); |
There was a problem hiding this comment.
I suggest using annotation_driver rather than the old alias (which was kept only for BC reasons)
There was a problem hiding this comment.
I assume you mean annotation_reader, right? I made that change -- thanks!
sarcher
force-pushed
the
annotationdriverfix
branch
from
2994811
to
6ff03b2
Compare
|
Rebased to current master; let me know if anything else needs to be done in order to get this merged. Thanks! |
|
Merged manually into 3.0 branch in bab5072. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this was a busted copy/paste from one of the other drivers; all this PR does is correct the arguments so that an annotations-based mappings pass works as expected.