Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to psalm 5 #764

Merged
merged 1 commit into from
Feb 5, 2023
Merged

Update to psalm 5 #764

merged 1 commit into from
Feb 5, 2023

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Jan 13, 2023

I've targeted 4.6.x because the template added to ServiceGridFSRepository.

The ignored errors are because

  • a while(true) in Command/TailCursorDoctrineODMCommand.php which psalm thinks that the return type must be never.
    - In ContainerRepositoryFactory, there is a $customRepositoryName variable that with type class-string|null and when doing if (! class_exists($customRepositoryName)) after if ($customRepositoryName !== null), psalm says All possible types for this argument were invalidated.
  • psalm/symfony-plugin added generics to AbstractType which seems not accurate, so we better don't use them.

psalm/symfony-plugin 5 requires php 7.4, so we need #763 or remove this dependency if it's not really useful (it will if we pass a path to the compiled container in XML).

@franmomu franmomu added the Task label Jan 13, 2023
@franmomu franmomu added this to the 4.6.0 milestone Jan 13, 2023
@franmomu franmomu force-pushed the update_psalm_5 branch 3 times, most recently from 011084b to dbfe394 Compare January 13, 2023 02:45
@franmomu franmomu force-pushed the update_psalm_5 branch 3 times, most recently from 32c581e to a1f36ed Compare February 5, 2023 14:29
@franmomu franmomu merged commit 06d075f into doctrine:4.6.x Feb 5, 2023
@franmomu franmomu deleted the update_psalm_5 branch February 5, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants