Fix missing driver instrumentation #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
fix-missing-instrumentation
branch
from
817641e
to
d2f5a8a
Compare
|
Note that a number of check failures are unrelated to the current. I'd like to revisit this in the 4.6.x branch. |
malarzm
approved these changes
Jul 20, 2023
| @@ -407,6 +412,11 @@ private function normalizeDriverOptions(array $connection) | |||
| $driverOptions['context'] = new Reference($driverOptions['context']); | |||
| } | |||
|
|
|||
| $driverOptions['driver'] = [ | |||
| 'name' => 'symfony-mongodb', | |||
| 'version' => self::getODMVersion(), | |||
There was a problem hiding this comment.
would it have more value if augmented with bundle's version as well?
There was a problem hiding this comment.
I don't think so. I'm not sure what other hosters use this for, but at MongoDB we use the data from MongoDB Atlas to judge version adoption and to influence strategic decisions (e.g. around what PHP versions to support/not support). In that sense the relevant info for us is a) the fact that someone is using the ODM through Symfony, and b) what ODM version they are using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ODM sends its own version data to servers to augment the driver version info. When using the bundle, the client isn't created by the DocumentManager, so this driver data is missing. This PR fixes this issue by adding the correct version info for Doctrine ODM.
Note that the added dependency is already a dependency of the ODM itself and does not add to the dependency chain. It is merely added here to avoid relying on a transitive dependency.